fix combination of --copy-ec and --from-pr#3482
Merged
ocaisa merged 52 commits intoeasybuilders:developfrom Nov 30, 2020
Merged
fix combination of --copy-ec and --from-pr#3482ocaisa merged 52 commits intoeasybuilders:developfrom
ocaisa merged 52 commits intoeasybuilders:developfrom
Conversation
…s + enhance test to catch the issue
This was referenced Oct 25, 2020
boegel
changed the title
boegel
force-pushed
the
copy-ec-from-pr
branch
from
eae7aaf to
bc2d08e
Compare
Member
Author
|
@ocaisa This should be good to go now, can you give it another look? |
ocaisa
requested changes
Nov 27, 2020
Member
ocaisa
left a comment
ocaisa
left a comment
There was a problem hiding this comment.
Looks good, just a typo, will take a deeper look while you fix that
ocaisa
requested changes
Nov 30, 2020
Member
ocaisa
left a comment
ocaisa
left a comment
There was a problem hiding this comment.
Looks good to me, one minor request
Member
|
also lgtm, fwiw (and more importantly, it works! :) ) |
boegel
force-pushed
the
copy-ec-from-pr
branch
from
7877704 to
3ce315a
Compare
ocaisa
approved these changes
Nov 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This continues from the work done by @ocaisa in #3473, and fixes the combination of
--copy-ecand--from-pr.The scope of this PR is pretty big, and I feel it should be split up into several PRs, so I made this a draft PR for now.
High level overview of additional changes:
--copy-filesfunction so it can be used to implement--copy-ec(both with and without--from-pr)enhance copy_files: single file target, error on empty input list, verbose mode #3483fetch_files_from_prcalls (mostly to significantly speed up tests)cache result of fetch_files_from_pr function #3484locate_filesfunction toeasybuild.tools.filetoolsmodule which can be leverared indet_easyconfig_pathsfunctionadd locate_files function to filetools module #3485download_repofunction fromeasybuild.tools.githubmodule changes working directorydon't change directory in download_repo function in tools.github #3486det_copy_ec_specsfunction to leverage frommain.py--copy-ecand--try-*pr_target_accountbuild option (only really relevant for tests)fixes #3178